From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V14 4/7] xen/arm: Data abort exception (R/W) mem_access events Date: Wed, 15 Apr 2015 14:53:38 +0100 Message-ID: <1429106018.15516.295.camel@citrix.com> References: <1427407531-31694-1-git-send-email-tklengyel@sec.in.tum.de> <1427407531-31694-5-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427407531-31694-5-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-03-26 at 23:05 +0100, Tamas K Lengyel wrote: > This patch enables to store, set, check and deliver LPAE R/W mem_events. > As the LPAE PTE's lack enough available software programmable bits, > we store the permissions in a Radix tree. The tree is only looked at if > mem_access_enabled is turned on. > > Signed-off-by: Tamas K Lengyel Apart from what Julien said (which you've addressed already for next time) this looks good to me now. Ian.