From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap Date: Wed, 15 Apr 2015 15:41:44 +0100 Message-ID: <1429108904.15516.307.camel@citrix.com> References: <1428405884-19431-1-git-send-email-baozich@gmail.com> <552511FA.5080800@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <552511FA.5080800@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Chen Baozi , julien.grall@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-04-08 at 12:33 +0100, Julien Grall wrote: > Hi Chen, > > On 07/04/15 12:24, Chen Baozi wrote: > > We have already had the boot pagetable when reaching the point > > s/had/added/ ? I think "switched too" is what was meant and more correct. > > of early_printk fixmap setup. Thus there is no longer necessary > > s/there is/it is/ ? Yes. > > to calculate physical address of xen_fixmap. > > > > Signed-off-by: Chen Baozi > > Other than the possible typoes above: > > Reviewed-by: Julien Grall Acked-by: Ian Campbell If it is confirmed that I got the correct meaning in the first one I can fix both on commit. Ian.