From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 03/28] libxl: suspend: switch_logdirty_done
 takes rc
Date: Wed, 15 Apr 2015 16:09:49 +0100
Message-ID: <1429110589.15516.323.camel@citrix.com>
References: <1427828465-25710-1-git-send-email-ian.jackson@eu.citrix.com>
	<1427828465-25710-4-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427828465-25710-4-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-03-31 at 20:00 +0100, Ian Jackson wrote:
> switch_logdirty_done used to take the value to pass to
> libxl__xc_domain_saverestore_async_callback_done (ie, the return value
> from the callback).  (This was mistakenly described as "ok" in the
> prototype, but in the definition it is "broke" and all the call sites
> passed 0 for success or -1 for error.)
> 
> Instead, make it take a libxl error code (rc).  Convert this to the
> suspend callback value at the end.
> 
> No functional change in this patch.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>