From: Ian Campbell <ian.campbell@citrix.com>
To: Emil Condrea <emilcondrea@gmail.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/2] vtpm: deep quote flags
Date: Wed, 15 Apr 2015 16:34:32 +0100 [thread overview]
Message-ID: <1429112072.15516.329.camel@citrix.com> (raw)
In-Reply-To: <CAAULxKKf79BtyempQOVmy49nHWWEQ3StYpRcEurwtzKj_2mwhw@mail.gmail.com>
On Wed, 2015-04-15 at 18:09 +0300, Emil Condrea wrote:
> Thanks! Should it remove it and resend the patches ?
I'll do it on commit (which I'm about to do).
>
> On Wed, Apr 15, 2015 at 6:07 PM, Daniel De Graaf
> <dgdegra@tycho.nsa.gov> wrote:
> On 04/14/2015 05:08 AM, Emil Condrea wrote:
> Currently, the flags are not interpreted by vTPM. They
> are just
> packed and sent to vtpmmgr.
>
> Signed-off-by: Emil Condrea <emilcondrea@gmail.com>
>
> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>
> [...]
> +- res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR,
> &req->auth1, &sigSize, &sig);
> ++ res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR,
> &req->auth1, extraInfoFlags,
> ++ "e_blob_size, "e_blob);
> + if (res != TPM_SUCCESS) return res;
> +- rsp->paramSize = len = sigSize;
> ++ rsp->paramSize = len =
> quote_blob_size;
>
> There's an extra tab at the start of this line.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
>
next prev parent reply other threads:[~2015-04-15 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 9:08 [PATCH v2 0/2] vtpm deep quote in locality 0 Emil Condrea
2015-04-14 9:08 ` [PATCH v2 1/2] vtpm: deep quote flags Emil Condrea
2015-04-15 15:07 ` Daniel De Graaf
2015-04-15 15:09 ` Emil Condrea
2015-04-15 15:34 ` Ian Campbell [this message]
2015-04-15 15:50 ` Ian Campbell
2015-04-15 17:33 ` Emil Condrea
2015-04-14 9:08 ` [PATCH v2 2/2] vtpmmgr: execute deep quote in locality 0 Emil Condrea
2015-04-15 15:07 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429112072.15516.329.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=emilcondrea@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.