From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
patches@apm.com, xen-devel@lists.xen.org,
stefano.stabellini@citrix.com, christoffer.dall@linaro.org,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Subject: Re: [PATCH] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk
Date: Wed, 15 Apr 2015 17:16:39 +0100 [thread overview]
Message-ID: <1429114599.25195.4.camel@citrix.com> (raw)
In-Reply-To: <5523B1A0.9040802@citrix.com>
On Tue, 2015-04-07 at 11:29 +0100, Julien Grall wrote:
> >> This would avoid to have this loop and rely on there is always only one
> >> interrupt controller in the DT.
> >
> > That is true, however we do know that on this SoC there is only one GIC,
> > so it might be acceptable to rely on this knowledge: this is already
> > very platform specific code.
>
> If we keep the loop, I would add a comment on the above the loop
> explaining that we rely on there is always only GIC.
>
> Although, I was wondering if we could simply rely on the node path to
> get the DT node?
If we know that all $OLD firmwares used the same path (or small set of
paths) then that could work.
Or the loop could be replaced with dt_find_interrupt_controller, passing
the known compatible value for the systems in question.
Ian.
next prev parent reply other threads:[~2015-04-15 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 8:54 [PATCH] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk Pranavkumar Sawargaonkar
2015-04-06 14:47 ` Julien Grall
2015-04-07 9:40 ` Stefano Stabellini
2015-04-07 10:29 ` Julien Grall
2015-04-15 16:16 ` Ian Campbell [this message]
2015-04-16 5:59 ` Pranavkumar Sawargaonkar
2015-04-08 8:28 ` Christoffer Dall
2015-04-13 6:12 ` Pranavkumar Sawargaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429114599.25195.4.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=christoffer.dall@linaro.org \
--cc=julien.grall@citrix.com \
--cc=patches@apm.com \
--cc=pranavkumar@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.