From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 06/19] xen: arm: add minimum exception level argument to trap handler helpers Date: Thu, 16 Apr 2015 17:24:13 +0100 Message-ID: <1429201453.25195.176.camel@citrix.com> References: <1427796446.2115.34.camel@citrix.com> <1427796462-24376-6-git-send-email-ian.campbell@citrix.com> <551E8E6C.8020400@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <551E8E6C.8020400@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, julien.grall@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-04-03 at 14:58 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Removes a load of boiler plate. > > > > Signed-off-by: Ian Campbell > > --- > > xen/arch/arm/traps.c | 65 +++++++++++++++++++++++++------------------------- > > 1 file changed, 32 insertions(+), 33 deletions(-) > > > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > > index ebc09f9..c9c98d3 100644 > > --- a/xen/arch/arm/traps.c > > +++ b/xen/arch/arm/traps.c > > @@ -1578,8 +1578,12 @@ static void advance_pc(struct cpu_user_regs *regs, const union hsr hsr) > > static void handle_raz_wi(struct cpu_user_regs *regs, > > register_t *reg, > > bool_t read, > > - const union hsr hsr) > > + const union hsr hsr, > > + int min_el) > > { > > I would add an ASSERT((min_el == 0) || (min_el == 1)) in order to make > clear that min_el should be either EL0 or EL1. Done for all cases, thanks.