From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 10/19] xen: arm: Annotate registers trapped by CPTR_EL2.TTA Date: Thu, 16 Apr 2015 17:45:20 +0100 Message-ID: <1429202720.25195.192.camel@citrix.com> References: <1427796446.2115.34.camel@citrix.com> <1427796462-24376-10-git-send-email-ian.campbell@citrix.com> <552269B3.1030200@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <552269B3.1030200@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, julien.grall@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-04-06 at 13:10 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Add explicit handler for 64-bit CP14 accesses, with more relevant > > debug message (as per other handlers) and to provide a place for the > > comment. > > It's a bit strange to name the patch "Annotate..." while the main change > is 64-bit CP14 accesses. I mostly started off annotating things, which lead me to notice things which are missing. I've retitled to "xen: arm: implement handling of registers trapped by CPTR_EL2.TTA" > AFAICT, this was a bug in Xen implementation. Although, I'm not sure if > the current platform we support have Trace registers (maybe the Arndale?). Hrm, good point. I'm not sure really. Ian.