From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [libvirt] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose). Date: Fri, 17 Apr 2015 09:58:33 +0100 Message-ID: <1429261113.25195.204.camel@citrix.com> References: <20150408144730.GA16160@l.oracle.com> <21805.20207.220139.608551@mariner.uk.xensource.com> <552FE703.3080208@suse.com> <21807.61130.841852.546321@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21807.61130.841852.546321@mariner.uk.xensource.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com To: Ian Jackson Cc: libvir-list@redhat.com, andrew.cooper3@citrix.com, xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On Thu, 2015-04-16 at 18:18 +0100, Ian Jackson wrote: > Jim Fehlig writes ("Re: [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose)."): > > On 04/14/2015 11:31 AM, Ian Jackson wrote: > > > I have produced what I think are two patches that will fix this. I > > > have compiled them but I haven't tested them. Konrad, are you able to > > > check whether they fix your bug ? > > > > I too saw this bug just before Konrad's report, but the patches don't seem to > > help. Running a script that continually saves and restores domains will > > eventually lock libvirtd with essentially the same traces reported by Konrad > > I'm a total idiot. I do the recheck but I don't pay any attention to > the result. Your second patch was updating revents which was used in the next if, what have I missed? > I will send an updated approach which does this centrally. Ack, that's probably best anyhow.