From: Ian Campbell <ian.campbell@citrix.com>
To: Jim Fehlig <jfehlig@suse.com>
Cc: libvir-list@redhat.com, Olaf Hering <olaf@aepfle.de>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: initialize vfb defbools in libxlMakeVfb
Date: Mon, 20 Apr 2015 09:39:03 +0100 [thread overview]
Message-ID: <1429519143.25195.363.camel@citrix.com> (raw)
In-Reply-To: <553161CA.2090906@suse.com>
On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > If the domU configu has sdl enabled libvirtd crashes:
> > libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
>
> The assertion seems harsh considering the offense...
libxl should be setting a default for this value if the application
hasn't, by calling libxl__device_vfb_setdefault at some correct point.
Not to say the application shouldn't also set it if it has a different
default preference, but there is a libxl bug here somewhere too.
Ian.
next prev parent reply other threads:[~2015-04-20 8:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1429291171-23640-1-git-send-email-olaf@aepfle.de>
2015-04-17 17:59 ` [PATCH] libxl: initialize vfb defbools in libxlMakeVfb Olaf Hering
2015-04-17 19:40 ` Jim Fehlig
[not found] ` <553161CA.2090906@suse.com>
2015-04-18 6:47 ` Olaf Hering
2015-04-20 8:39 ` Ian Campbell [this message]
2015-04-20 9:32 ` Olaf Hering
2015-04-20 9:43 ` Ian Campbell
2015-04-20 10:20 ` Olaf Hering
2015-04-20 10:25 ` Ian Campbell
2015-04-20 10:32 ` Olaf Hering
2015-04-20 11:10 ` Ian Campbell
[not found] ` <20150418064723.GA2488@aepfle.de>
2015-04-24 20:05 ` Jim Fehlig
[not found] ` <20150417175928.GA2516@aepfle.de>
2015-04-17 19:57 ` Jim Fehlig
2015-04-18 6:50 ` Olaf Hering
2015-05-01 13:45 ` Ian Campbell
[not found] ` <1430487940.15640.32.camel@citrix.com>
2015-05-01 15:10 ` Jim Fehlig
2015-05-05 12:01 ` Ian Campbell
2015-05-06 8:24 ` Olaf Hering
[not found] ` <20150506082454.GB10182@aepfle.de>
2015-05-06 9:08 ` Ian Campbell
[not found] ` <1430903289.2660.169.camel@citrix.com>
2015-05-06 9:15 ` Ian Campbell
2015-05-06 9:18 ` Olaf Hering
2015-04-24 20:19 ` Jim Fehlig
2015-04-17 17:19 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429519143.25195.363.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.