From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 11/13] tools/libxl: add command to show
 CMT hardware info
Date: Tue, 21 Apr 2015 02:37:54 +0200
Message-ID: <1429576674.18926.3.camel@citrix.com>
References: <1429281230-4352-1-git-send-email-chao.p.peng@linux.intel.com>
	<1429281230-4352-12-git-send-email-chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3966241520068326415=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429281230-4352-12-git-send-email-chao.p.peng@linux.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

--===============3966241520068326415==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-mkgBayRpr8sYfghob/oM"

--=-mkgBayRpr8sYfghob/oM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote:
> Add dedicated one to show hardware information.
>=20
> [root@vmm-psr]xl psr-cmt-hwinfo
> Cache Monitoring Technology (CMT):
> Enabled         : 1
> Total RMID      : 63
> Supported monitor types:
> cache-occupancy
> total-mem-bandwidth
> local-mem-bandwidth
>=20
Nice.

> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>

> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -8014,6 +8014,36 @@ out:
>  }
> =20
>  #ifdef LIBXL_HAVE_PSR_CMT
> +static int psr_cmt_hwinfo(void)
> +{
> +    int rc;
> +    int enabled;
> +    uint32_t total_rmid;
> +
>
I think you should still have something like:

    SWITCH_FOREACH_OPT(opt, "", NULL, "psr-cmt-hwinfo", 0) {
        /* No options */
    }

Or `xl psr-cmt-hwinfo -h' wouldn't work, would it?

With that done:

 Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario

--=-mkgBayRpr8sYfghob/oM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlU1m+IACgkQk4XaBE3IOsQkuQCeKCsAQtPrVZi4ku/Lxl/ADn8f
Ja8AnRnkN5cVjpzMjCDCAUkZlkXXHtc6
=TkYv
-----END PGP SIGNATURE-----

--=-mkgBayRpr8sYfghob/oM--


--===============3966241520068326415==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3966241520068326415==--