From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 13/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDRA Date: Tue, 21 Apr 2015 09:42:12 +0100 Message-ID: <1429605732.25195.470.camel@citrix.com> References: <1427796446.2115.34.camel@citrix.com> <1427796462-24376-13-git-send-email-ian.campbell@citrix.com> <55228920.6020304@citrix.com> <1429271481.25195.280.camel@citrix.com> <553609D1.4020603@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <553609D1.4020603@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xen.org, julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-04-21 at 13:26 +0500, Julien Grall wrote: > Hi Ian, > > On 17/04/2015 16:51, Ian Campbell wrote: > >> Furthermore, this is the only registers not handled on AArch32 for this > >> bit. This is rather strange to list them while you didn't do it for the > >> trace registers. > > > > My intention was that every register trapped by a bit which we set be > > listed somewhere, to make it easier to cross reference with the docs and > > check we haven't accidentally forgotten something (as opposed to > > deliberately ignoring as indicated by these comments). > > > > You seem to be saying I've missed some trace registers, which ones? > > I meant that you didn't list the trace registers trapped but unhandled. > Although I wasn't able to find a list, is it trace module specific? If > so maybe a comment would be good? I think maybe you are talking about the things trapped by CPTR_EL2.TTA rather than MDCR_EL2.TDRA (the subject of this patch)? The table referenced for CPTR_EL2.TTA just says "All implemented trace registers", rather than listing anything specific. I could add a similar comment to the relevant patch. Looks like HCR_EL2.TIDCP is similarly lacking a comment for the unhandled ones. I'll add one. > > Regards, >