From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v8 7/7] Add test job for nest
	test case
Date: Tue, 21 Apr 2015 11:51:09 +0100
Message-ID: <1429613469.4743.46.camel@citrix.com>
References: <1428959990-24199-1-git-send-email-longtaox.pang@intel.com>
	<1428959990-24199-8-git-send-email-longtaox.pang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1428959990-24199-8-git-send-email-longtaox.pang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "longtao.pang" <longtaox.pang@intel.com>
Cc: wei.liu2@citrix.com, robert.hu@intel.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote:
> 1. This patch adds creation of the nested test job, when job creation
> procedure is invoked.
> 2. Set nested L1's vif model as e1000 by make-flight.
> 
> Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> ---
> Changes in v8:
> 1. Use 'nestedl1' and 'nestedl2' as L1 and L2's clearer name in nested
> test job.
> 2. Setting Debian_ISO as 'debian-7.2.0-amd64-CD-1.iso' in make-flight.
> ---
>  make-flight |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/make-flight b/make-flight
> index cc8ecdb..40ca808 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -204,6 +204,25 @@ do_hvm_win7_x64_tests () {
>              all_hostflags=$most_hostflags,hvm
>  }
>  
> +do_hvm_debian_nested_tests () {
> +  if [ $xenarch != amd64 -a $dom0arch != amd64 ]; then
> +    return
> +  fi
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> +                        $xenarch $dom0arch \
> +            nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> +            bios=seabios \
> +            kernbuildjob=build-amd64-pvops \
> +            kernkind=pvops \
> +            nestedl1_vifmodel='e1000' \
> +            nested_disk='15000' \

Should be nestedl1_disk I think.

It would be best to group nestedl1_* and nestedl2_* together in the
list, rather than having image up above. i.e.

            nestedl1_vifmodel='e1000' \
            nestedl1_memory='3072' \
            nestedl1_disk='15000' \
            nestedl1_image='....' \
            nestedl1_foo='bar' \
            nestedl2_disk='20000' \
            nestedl2_foo='baz' \
etc.

Ian.