From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/configure.ac: generate Paths.mk if it's not available Date: Tue, 21 Apr 2015 11:54:27 +0100 Message-ID: <1429613667.4743.49.camel@citrix.com> References: <1429538858-23122-1-git-send-email-wei.liu2@citrix.com> <20150421101627.GA24062@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150421101627.GA24062@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-04-21 at 11:16 +0100, Wei Liu wrote: > On Mon, Apr 20, 2015 at 03:07:38PM +0100, Wei Liu wrote: > > Xen toolstack references many variables in Paths.mk when building and > > installing, so tools' configure should generate Paths.mk if it's not > > available. Also make inclusion of Paths.mk mandatory in Tools.mk. > > Hmm... I just discovered that docs build also involves Paths.mk. This > patch is ugly enough that I don't want to duplicate it for docs. > So advise on how to fix this would be much appreciated. I wasn't terribly happy with having more than one place update Paths.mk already. > Or we can state clear that anyone who builds Xen from source needs to > run ./configure in top level directory, not the ones in subsystems. I think that's essentially what we've done so far, but it's not terribly satisfactory I'll admit. Is this the only issue which prevents this? Perhaps change each subsystem to generate+consume its own Paths ${subsys}.mk instead of a single global one? Either in config/Paths ${subsys.mk} or in ${subsys}/Paths.mk. If you invoke from the top-level then they will all end up with the same contents, but so what... Ian.