From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" Date: Tue, 21 Apr 2015 14:18:54 +0300 Message-ID: <1429615134.15866.14.camel@linaro.org> References: <1429600263-4366-1-git-send-email-ivan.ivanov@linaro.org> <5C67DC9B092C4B1AAF6698027419ED92@sisodomain.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5C67DC9B092C4B1AAF6698027419ED92@sisodomain.com> Sender: linux-kernel-owner@vger.kernel.org To: Vivek Gautam Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Tue, 2015-04-21 at 16:46 +0530, Vivek Gautam wrote: > Hi, > > On Tuesday, April 21, 2015 12:41 PM "Ivan T. Ivanov" > ivanov@linaro.org> wrote: > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > > devm_ioremap_resource instead of devm_ioremap"), because msm_otg > > and this driver are using same address space to access AHB mode > > and USB command registers. > > > > Cc: Vivek Gautam vivek@samsung.com> > > Since ehci-msm and msm_otg both want to control few USB registers, > it makes sense to request ioremap'ed region in both drivers. > > Acked-by: Vivek Gautam vivek@samsung.com> > > I can see a patch in mailing list for adding both ehci-host and otg on msm > [1]. > But I think it has not yet made it to mainline kernel. > > [1] [v3,04/11] ARM: dts: apq8064: Add USB OTG support > https://patches.linaro.org/47067/ Thanks. Ivan