All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/configure.ac: generate Paths.mk if it's not available
Date: Tue, 21 Apr 2015 13:44:51 +0100	[thread overview]
Message-ID: <1429620291.4743.60.camel@citrix.com> (raw)
In-Reply-To: <20150421113018.GB24062@zion.uk.xensource.com>

On Tue, 2015-04-21 at 12:30 +0100, Wei Liu wrote:
> On Tue, Apr 21, 2015 at 11:54:27AM +0100, Ian Campbell wrote:
> > On Tue, 2015-04-21 at 11:16 +0100, Wei Liu wrote:
> > > On Mon, Apr 20, 2015 at 03:07:38PM +0100, Wei Liu wrote:
> > > > Xen toolstack references many variables in Paths.mk when building and
> > > > installing, so tools' configure should generate Paths.mk if it's not
> > > > available. Also make inclusion of Paths.mk mandatory in Tools.mk.
> > > 
> > > Hmm... I just discovered that docs build also involves Paths.mk.  This
> > > patch is ugly enough that I don't want to duplicate it for docs.
> > > So advise on how to fix this would be much appreciated.
> > 
> > I wasn't terribly happy with having more than one place update Paths.mk
> > already.
> > 
> > > Or we can state clear that anyone who builds Xen from source needs to
> > > run ./configure in top level directory, not the ones in subsystems.
> > 
> > I think that's essentially what we've done so far, but it's not terribly
> > satisfactory I'll admit. Is this the only issue which prevents this?
> > 
> > Perhaps change each subsystem to generate+consume its own Paths
> > ${subsys}.mk instead of a single global one? Either in config/Paths
> > ${subsys.mk} or in ${subsys}/Paths.mk.
> > 
> > If you invoke from the top-level then they will all end up with the same
> > contents, but so what...
> > 
> 
> I can try to refactor Paths.mk.in into several files.

I was suggesting a single input but create multiple outputs, otherwise
we have to keep all the inputs in sync.

I expect the majority of paths are common to all sub components.

Ian.

      reply	other threads:[~2015-04-21 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 14:07 [PATCH] tools/configure.ac: generate Paths.mk if it's not available Wei Liu
2015-04-21 10:16 ` Wei Liu
2015-04-21 10:54   ` Ian Campbell
2015-04-21 11:30     ` Wei Liu
2015-04-21 12:44       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429620291.4743.60.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.