From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V15 2/9] xen/arm: Allow hypervisor access to
 mem_access protected pages
Date: Tue, 21 Apr 2015 14:14:12 +0100
Message-ID: <1429622052.4743.77.camel@citrix.com>
References: <1429542384-23905-1-git-send-email-tklengyel@sec.in.tum.de>
	<1429542384-23905-3-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429542384-23905-3-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-04-20 at 17:06 +0200, Tamas K Lengyel wrote:
> -paddr_t p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)
> +static paddr_t __p2m_lookup(struct domain *d, paddr_t paddr, p2m_type_t *t)

I'd have been inclined to make this take a p2m_domain* rather than a
domain*, on the basis that the caller must have one in hand to have
locked it. I don't think __p2m_lookup uses d other than to find the p2m.

Not worth changing unless there is some other reason to resend though,
so with or without that:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.