From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in
 TestSupport.pm for nested test
Date: Tue, 21 Apr 2015 14:41:48 +0100
Message-ID: <1429623708.4743.97.camel@citrix.com>
References: <1428959990-24199-1-git-send-email-longtaox.pang@intel.com>
	<1428959990-24199-4-git-send-email-longtaox.pang@intel.com>
	<1429611542.4743.22.camel@citrix.com>
	<21814.17314.479011.970684@mariner.uk.xensource.com>
	<1429620780.4743.67.camel@citrix.com>
	<21814.20580.723370.301076@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21814.20580.723370.301076@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: robert.hu@intel.com, "longtao.pang" <longtaox.pang@intel.com>, wei.liu2@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test"):
> > On Tue, 2015-04-21 at 13:33 +0100, Ian Jackson wrote:
> > > It seems to be copying information from runvars into the in-memory
> > > data structure for host properties.  But host properties are (by
> > > definition) matters of (fixed) configuration, not runtime definition.
> > 
> > Remember that here the "host" is actual an L1 virtual machine, whose IP
> > is not fixed (since it mac address isn't).
> 
> Indeed.
> 
> > I don't know if that affects your opinion at all?
> 
> No, it doesn't.  I agree that the IP address should be dynamically
> figured out, and passing it through a runvar is fine.
> 
> I'm only objecting to the involvement of the host property machinery.

I'm afraid I'm not 100% sure I understand, but do you just mean that
longtao should assign to $ho->{Ip} directly within selecthost instead of
using $setprop to set the IpAddr hostprop and therefore indirectly
->{Ip}?

IOW the existing code in selecthost which looks up the IpAddr host prop
into $ho->{IpStatic} and then into $ho->{Ip} should prefer the runvar to
the host db if it is set?

BTW, what is the difference between ->{Ip} and ->{IpStatic} and should
the runvar be reflected in both or just in ->{Ip}?

Ian.