From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 13/13] docs: add xl-psr.markdown
Date: Tue, 21 Apr 2015 15:05:33 +0100
Message-ID: <1429625133.4743.105.camel@citrix.com>
References: <1429281230-4352-1-git-send-email-chao.p.peng@linux.intel.com>
	<1429281230-4352-14-git-send-email-chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429281230-4352-14-git-send-email-chao.p.peng@linux.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote:
> @@ -1534,7 +1540,8 @@ Show CAT hardware information.
>  
>  =item B<psr-cat-cbm-set> [I<OPTIONS>] I<domain-id> I<cbm>
>  
> -Set cache capacity bitmasks(CBM) for a domain.
> +Set cache capacity bitmasks(CBM) for a domain. For how to specify I<cbm>
> +please refer to the link above.

I think the "link above" is to far. I think say something more explicit
like L<xl-psr.txt> ?

>  
>  B<OPTIONS>
>  
> @@ -1575,6 +1582,7 @@ And the following documents on the xen.org website:
>  L<http://xenbits.xen.org/docs/unstable/misc/xl-network-configuration.html>
>  L<http://xenbits.xen.org/docs/unstable/misc/xl-disk-configuration.txt>
>  L<http://xenbits.xen.org/docs/unstable/misc/xsm-flask.txt>
> +L<http://xenbits.xen.org/docs/unstable/misc/xl-psr.html>
>  
>  For systems that don't automatically bring CPU online:
>  
> diff --git a/docs/misc/xl-psr.markdown b/docs/misc/xl-psr.markdown
> new file mode 100644
> index 0000000..d167b84
> --- /dev/null
> +++ b/docs/misc/xl-psr.markdown
> @@ -0,0 +1,134 @@
> +# Intel Platform Shared Resource Monitoring/Control in xl
> +
> +This document introduces Intel Platform Shared Resource Monitoring/Control
> +technologies, their basic concepts and the xl interfaces.
> +
> +## Cache Monitoring Technology (CMT)
> +
> +Cache Monitoring Technology (CMT) is a new feature available on Intel Haswell
> +and later server platforms that allows an OS or Hypervisor/VMM to determine
> +the usage of cache(currently only L3 cache supported) by applications running
                     ^space before ( please.

> +For example, assuming a system with 8 portions and 3 domains:
> +
> +        A CBM of 0xff for every domain means each domain can access the
> +        whole cache. This is the default.
> +
> +        Giving one domain a CBM of 0x0f and the other two domain's 0xf0
> +        means that the first domain gets exclusive access to half of the
> +        cache (half of the portions) and the other two will share the
> +        other half.
> +
> +        Giving one domain a CBM of 0x0f, one 0x30 and the last 0xc0
> +        would give the first domain exclusive access to half the cache,
> +        and the other two exclusive access to one quarter each.

How does markdown render this? I think you might want to start each para
with a * to make it a bullet list.

Other than those minor things all looks good, thanks.

Ian.