From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/7] docs/build: Do not open-code $*
Date: Tue, 21 Apr 2015 15:10:56 +0100 [thread overview]
Message-ID: <1429625456.4743.107.camel@citrix.com> (raw)
In-Reply-To: <1429526966-18874-3-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2015-04-20 at 11:49 +0100, Andrew Cooper wrote:
> Sometimes there is already a round enough wheel to hand.
I love the double use of sed and the unescaped .'s.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
(I agree with the conclusion of the subthread that we needn't worry
about quoting here, at least not in isolation wrt $@ $< etc)
next prev parent reply other threads:[~2015-04-21 14:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 10:49 [PATCH 0/7] docs/build fixes Andrew Cooper
2015-04-20 10:49 ` [PATCH 1/7] docs/build: Misc cleanup Andrew Cooper
2015-04-21 14:08 ` Ian Campbell
2015-04-20 10:49 ` [PATCH 2/7] docs/build: Do not open-code $* Andrew Cooper
2015-04-20 11:48 ` Jan Beulich
2015-04-20 11:55 ` Andrew Cooper
2015-04-20 12:13 ` Jan Beulich
2015-04-21 14:10 ` Ian Campbell [this message]
2015-04-20 10:49 ` [PATCH 3/7] docs/build: Move two rules for consistency, and comment sections Andrew Cooper
2015-04-21 14:11 ` Ian Campbell
2015-04-20 10:49 ` [PATCH 4/7] docs/build: Do not use move-if-changed Andrew Cooper
2015-04-21 14:12 ` Ian Campbell
2015-04-21 15:00 ` Andrew Cooper
2015-04-21 15:03 ` Ian Campbell
2015-04-20 10:49 ` [PATCH 5/7] docs/build: Do not create directories if we are not going to use them Andrew Cooper
2015-04-21 14:13 ` Ian Campbell
2015-04-20 10:49 ` [PATCH 6/7] docs/build: Move install checks into individual build targets Andrew Cooper
2015-04-20 11:57 ` Jan Beulich
2015-04-20 12:01 ` Andrew Cooper
2015-04-21 14:15 ` Ian Campbell
2015-04-21 14:18 ` Jan Beulich
2015-04-21 14:23 ` Ian Campbell
2015-04-21 14:55 ` Andrew Cooper
2015-04-21 15:47 ` [PATCH v2 " Andrew Cooper
2015-04-21 15:50 ` Andrew Cooper
2015-04-21 15:47 ` [PATCH v2 7/7] docs/build: Support generation of pandoc documents Andrew Cooper
2015-04-20 10:49 ` [PATCH " Andrew Cooper
2015-04-21 14:15 ` Ian Campbell
2015-04-22 14:22 ` [PATCH 0/7] docs/build fixes Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429625456.4743.107.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.