From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm: Fix undefined reference to drm_agp_clear() on
	non-AGP platforms
Date: Wed, 07 Aug 2013 14:39:40 +0200
Message-ID: <1429663.aMUVjXR5F5@avalon>
References: <1375877860-25203-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
	<CAKMK7uEapKEr1HtDDsHLep2+dwnn-Ew_FYnBte2giWFsXV6WfA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[95.142.166.194])
	by gabe.freedesktop.org (Postfix) with ESMTP id B72CDE643F
	for <dri-devel@lists.freedesktop.org>;
	Wed,  7 Aug 2013 05:38:35 -0700 (PDT)
In-Reply-To: <CAKMK7uEapKEr1HtDDsHLep2+dwnn-Ew_FYnBte2giWFsXV6WfA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

Hi Daniel,

On Wednesday 07 August 2013 14:19:34 Daniel Vetter wrote:
> On Wed, Aug 7, 2013 at 2:17 PM, Laurent Pinchart wrote:
> > The drm_agp_clear() function is only defined on platforms with AGP
> > support. Move the drm_core_has_AGP() check from drm_agp_clear() to the
> > caller to let the compiler optimize the drm_agp_clear() call away.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Can't we use the usual approach of an empty static inline helper for
> the !CONFIG_AGP case here?

Sure, that's possible as well. I find my solution slightly more explicit as it 
shows that drm_agp_clear() will only be called for platforms that have AGP, 
but I would be fine with a static inline as well.

-- 
Regards,

Laurent Pinchart