From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v8 6/7] Compose the main
 recipe of nested test job
Date: Wed, 22 Apr 2015 12:04:41 +0100
Message-ID: <1429700681.6604.20.camel@citrix.com>
References: <1428959990-24199-1-git-send-email-longtaox.pang@intel.com>
	<1428959990-24199-7-git-send-email-longtaox.pang@intel.com>
	<1429613324.4743.44.camel@citrix.com>
	<86C3224E41A7434B904EC364302132D80E49863A@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <86C3224E41A7434B904EC364302132D80E49863A@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Pang, LongtaoX" <longtaox.pang@intel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>, "Hu,
	Robert" <robert.hu@intel.com>, "Ian.Jackson@eu.citrix.com" <Ian.Jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-04-22 at 08:38 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Tuesday, April 21, 2015 6:49 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com; Hu,
> > Robert
> > Subject: Re: [OSSTEST Nested PATCH v8 6/7] Compose the main recipe of nested
> > test job
> > 
> > On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote:
> > > Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> > > ---
> > > Changes in v8:
> > > Change the patch order from 6 to 5.
> > > ---
> > >  sg-run-job |   11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/sg-run-job b/sg-run-job
> > > index eae159d..2ca5ebf 100755
> > > --- a/sg-run-job
> > > +++ b/sg-run-job
> > > @@ -299,6 +299,17 @@ proc run-job/test-pair {} {
> > >  #    run-ts . remus-failover ts-remus-check         src_host dst_host +
> > debian
> > >  }
> > >
> > > +proc need-hosts/test-nested {} {return host}
> > > +proc run-job/test-nested {} {
> > > +    run-ts . = ts-debian-hvm-install + host + nestedl1
> > > +    run-ts . = ts-nested-setup + host + nestedl1
> > > +    run-ts . = ts-xen-install nested_l1
> > > +    run-ts . = ts-host-reboot nested_l1
> > > +    run-ts . = ts-debian-hvm-install nested_l1 nestedl2
> > > +    run-ts . = ts-guest-stop nested_l1 nestedl2
> > > +    run-ts . = ts-guest-destroy host nestedl1
> > 
> > Based on my comments to previous patches I think you'll want to use
> > nestedl1 and nestedl2 consistently and never nested_l1/nested_l2.
> > 
> nestedl1 nestedl2 are hostname for L1 guest VM and L2 guest VM,
> nested_l1 and nested_l2 are ident for L1 and L2.

Hostnames shouldn't be appearing in this script, I don't think,
certainly not bare like that.

For the physical i.e. l0 case I think what happens is that
need-hosts/foo ends up returning a bunch of $ident=$an_actual_host. i.e.
srchost=$hosta and dsthost=$hostb.

I'm not sure how that would work in the nested world, but maybe you
should be writing $ident=$guestname (i.e. nested_l1=nestedl1)?

Ian?