From: Joe Perches <joe@perches.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, Sathya Perla <sathya.perla@emulex.com>,
Subbu Seetharaman <subbu.seetharaman@emulex.com>,
Ajit Khaparde <ajit.khaparde@emulex.com>
Subject: Re: [PATCH net-next] be2net: log link status
Date: Wed, 22 Apr 2015 06:10:55 -0700 [thread overview]
Message-ID: <1429708255.31675.42.camel@perches.com> (raw)
In-Reply-To: <1429707370-2792-1-git-send-email-ivecera@redhat.com>
On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
> The driver unlike other drivers does not log link state changes.
[]
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
[]
> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
> netif_carrier_on(netdev);
> else
> netif_carrier_off(netdev);
> +
> + netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
> }
If this is valuable, it's also valuable to emit the
link speed/duplex states like most other drivers.
next prev parent reply other threads:[~2015-04-22 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 12:56 [PATCH net-next] be2net: log link status Ivan Vecera
2015-04-22 13:10 ` Joe Perches [this message]
2015-04-22 13:22 ` Ivan Vecera
2015-04-23 8:30 ` Sathya Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429708255.31675.42.camel@perches.com \
--to=joe@perches.com \
--cc=ajit.khaparde@emulex.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.