From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7] libxl: provide libxl_bitmap_{or,and} Date: Wed, 22 Apr 2015 15:21:07 +0100 Message-ID: <1429712467.30934.18.camel@citrix.com> References: <1429117327-6845-1-git-send-email-lindaj@jma3.com> <1429194854.25195.134.camel@citrix.com> <552FC9F4.80207@jma3.com> <20150416144557.GF13154@zion.uk.xensource.com> <552FE80D.9000908@jma3.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YkvXq-0003v3-Or for xen-devel@lists.xenproject.org; Wed, 22 Apr 2015 14:22:30 +0000 In-Reply-To: <552FE80D.9000908@jma3.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Linda Cc: Wei Liu , stefano.stabellini@eu.citrix.com, lars.kurth.xen@gmail.com, julien.grall@citrix.com, ian.jackson@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-04-16 at 10:49 -0600, Linda wrote: > On 4/16/2015 8:45 AM, Wei Liu wrote: > > On Thu, Apr 16, 2015 at 08:40:52AM -0600, Linda wrote: > >> On 4/16/2015 8:34 AM, Ian Campbell wrote: > >>> On Wed, 2015-04-15 at 11:02 -0600, Linda Jacobson wrote: > >>>> New functions to provide logical and and or of two bitmaps functions can be > >>>> used in vNUMA configuration check function. > >>> I don't think that really justifies adding them, since we aren't > >>> actually using them for that now, how about: > >>> > >>> New functions to provide logical and and or of two bitmaps. > >>> These are generically useful utility functions added to the > >>> public API for the benefit of libxl's users. > >>> In the future they may also be useful internally, e.g. in the > >>> vNUMA configuration check function. > >>> > >>> If you are happy with that, and there's no other reason to resend, then > >>> I can switch in that text as I commit. > >> I'm fine with this. If Wei and Julien are, please go ahead. > > Julien is away now. I'm of course fine with this -- it's your > > contribution after all, you have the final say. :-) > Then, Ian, please, go ahead. Done, thanks. I had to apply with "git am --whitespace=fixup" due to the trailing whitespace which the patches added. Ian