All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: "Gustau Pérez" <gustau.perez@gmail.com>
Cc: xen-devel@lists.xenproject.org, "Wei Liu" <wei.liu2@citrix.com>,
	"Ian Jackson" <Ian.Jackson@eu.citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD.
Date: Wed, 22 Apr 2015 15:21:48 +0100	[thread overview]
Message-ID: <1429712508.30934.21.camel@citrix.com> (raw)
In-Reply-To: <5534D327.8050007@gmail.com>

On Mon, 2015-04-20 at 12:21 +0200, Gustau Pérez wrote:
> 
> On 20/04/2015 12:01, Wei Liu wrote:
> > On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monné wrote:
> >> El 20/04/15 a les 9.12, Gustau Perez ha escrit:
> >>> On creation time, tap and xnb interfaces are created with an mtu of
> >>> 1500 bytes, assuming the bridge will have the same value.
> >>> Instead, check the bridge mtu and configure the new xnb or
> >>> tap interface with the same value.
> >>>
> >>> The tools used are sed and ifconfig, both included on base. No need
> >>> to install additional ports (no new dependences).
> >>>
> >>> Signed-off-by: Gustau Perez <gustau.perez@gmail.com>
> >> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> +CCing the tools maintainers.
> >>
> > The patch title is a bit cryptic. Maybe change it to:
> >
> >   hotplug: set network interface MTU to bridge MTU on FreeBSD
> >
> > ?
> >
> > In any case
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Wei.
> 
>    Seems fine to me.

I went with "hotplug/FreeBSD: set network interface MTU to bridge MTU".
Acked + applied, thanks.

> 
>    Best,
> 
>    G.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2015-04-22 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  7:12 [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD Gustau Perez
2015-04-20  9:25 ` Roger Pau Monné
2015-04-20 10:01   ` Wei Liu
2015-04-20 10:21     ` Gustau Pérez
2015-04-22 14:21       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429712508.30934.21.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=gustau.perez@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.