From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH COLO v5 02/29] Refactor domain_suspend_callback_common() Date: Wed, 22 Apr 2015 15:45:15 +0100 Message-ID: <1429713915.30934.32.camel@citrix.com> References: <1427870525-18686-1-git-send-email-yanghy@cn.fujitsu.com> <1427870525-18686-3-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427870525-18686-3-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, ian.jackson@eu.citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote: > The core function to suspend vm is domain_suspend_callback_common(). > So use a new structure libxl__domain_suspend_state2 to > instead of libxl__domain_suspend_state. The dss's members that > will be used in domain_suspend_callback_common() are > moved to dss2. Please can we try and find a more semantically meaningful name than appending a 2 to everything.