From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST Nested PATCH v8 4/7] Changes on test step of Debian hvm guest install Date: Thu, 23 Apr 2015 13:04:42 +0100 Message-ID: <1429790682.12403.45.camel@citrix.com> References: <1428959990-24199-1-git-send-email-longtaox.pang@intel.com> <1428959990-24199-5-git-send-email-longtaox.pang@intel.com> <1429612114.4743.29.camel@citrix.com> <1429768761.31307.17.camel@localhost> <1429771963.16578.17.camel@citrix.com> <9E79D1C9A97CFD4097BCE431828FDD31BBAC90@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31BBAC90@SHSMSX103.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Hu, Robert" Cc: "wei.liu2@citrix.com" , "Pang, LongtaoX" , "Ian.Jackson@eu.citrix.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2015-04-23 at 10:43 +0000, Hu, Robert wrote: > > If/when the other ts-*-install need to support sizing the disk based on > > a runvar they would need similar changes. If you want to make those now > > for consistency then that would be great, but I don't think it needs to > > be mandatory. > I would prefer to leaving $disk_mb 'our' at present; to be consistent with other > ts-*-installs. > Meanwhile do the overriding by runvar value in prepareguest(). > Are you OK with this? It sounds like Ian is OK with this idea at least in principal, so sure. Please do this the same for both disk and memory. Ian.