All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [RFC PATCH 1/8] distributor: remove header inclusion of mbuf.h
Date: Thu, 23 Apr 2015 14:03:50 +0100	[thread overview]
Message-ID: <1429794237-9498-2-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1429794237-9498-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

The distributor header file includes the mbuf header file, but it does not
need to do so as it only uses pointers to the struct rte_mbuf type, and
does not use any of the mbuf internals, nor any of the mbuf functions or
macros. Therefore the inclusion is unnecessary, and can be replaced by a
forward declaration of the mbuf type.

Signed-off-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 app/test/test_distributor.c              | 2 ++
 app/test/test_distributor_perf.c         | 3 +++
 lib/librte_distributor/rte_distributor.h | 3 +--
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index 9e8c06d..c8c0942 100644
--- a/app/test/test_distributor.c
+++ b/app/test/test_distributor.c
@@ -37,6 +37,8 @@
 #include <string.h>
 #include <rte_cycles.h>
 #include <rte_errno.h>
+#include <rte_mempool.h>
+#include <rte_mbuf.h>
 #include <rte_distributor.h>
 
 #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */
diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c
index 31431bb..234a37e 100644
--- a/app/test/test_distributor_perf.c
+++ b/app/test/test_distributor_perf.c
@@ -35,7 +35,10 @@
 
 #include <unistd.h>
 #include <string.h>
+#include <rte_mempool.h>
 #include <rte_cycles.h>
+#include <rte_common.h>
+#include <rte_mbuf.h>
 #include <rte_distributor.h>
 
 #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */
diff --git a/lib/librte_distributor/rte_distributor.h b/lib/librte_distributor/rte_distributor.h
index cc1d559..7d36bc8 100644
--- a/lib/librte_distributor/rte_distributor.h
+++ b/lib/librte_distributor/rte_distributor.h
@@ -46,11 +46,10 @@
 extern "C" {
 #endif
 
-#include <rte_mbuf.h>
-
 #define RTE_DISTRIBUTOR_NAMESIZE 32 /**< Length of name for instance */
 
 struct rte_distributor;
+struct rte_mbuf;
 
 /**
  * Function to create a new distributor instance
-- 
2.1.0

  parent reply	other threads:[~2015-04-23 13:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 13:03 [RFC PATCH 0/8] reduce header dependency on rte_mbuf.h Bruce Richardson
     [not found] ` <1429794237-9498-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-23 13:03   ` Bruce Richardson [this message]
2015-04-23 13:03   ` [RFC PATCH 2/8] ethdev: remove inclusion of rte_mbuf.h Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 3/8] kni: remove header " Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 4/8] ip_frag: " Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 5/8] pipeline: " Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 6/8] virtio: " Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 7/8] table: " Bruce Richardson
2015-04-23 13:03   ` [RFC PATCH 8/8] vhost: " Bruce Richardson
2015-05-04  8:18   ` [RFC PATCH 0/8] reduce header dependency on rte_mbuf.h Olivier MATZ
2015-05-11 13:34     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429794237-9498-2-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.