From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support
Date: Tue, 4 Mar 2025 11:59:53 +0100 [thread overview]
Message-ID: <142a2edc-a668-4a6a-a4e8-eff3e8bf9e91@kernel.org> (raw)
In-Reply-To: <20250304104434.481429-3-kevin_chen@aspeedtech.com>
On 04/03/2025 11:44, Kevin Chen wrote:
> The AST2600 has PCC controller in LPC, placed in LPC node.
>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> index 8ed715bd53aa..87dcacb78692 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> @@ -626,6 +626,13 @@ lpc_snoop: lpc-snoop@80 {
> status = "disabled";
> };
>
> + lpc_pcc: lpc-pcc@0 {
> + compatible = "aspeed,ast2600-lpc-pcc";
> + reg = <0x0 0x140>;
> + interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
Incomplete. Your driver clearly bails on missing ports...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-04 11:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 10:44 Add AST2600 LPC PCC support Kevin Chen
2025-03-04 10:44 ` [PATCH v2 1/3] dt-binding: aspeed: Add LPC PCC controller Kevin Chen
2025-03-05 6:38 ` Krzysztof Kozlowski
2025-03-10 1:50 ` Kevin Chen
2025-03-10 7:15 ` Krzysztof Kozlowski
2025-03-10 9:49 ` Kevin Chen
2025-03-10 11:42 ` Krzysztof Kozlowski
2025-03-11 0:22 ` Kevin Chen
2025-03-04 10:44 ` [PATCH v2 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support Kevin Chen
2025-03-04 10:59 ` Krzysztof Kozlowski [this message]
2025-03-14 10:39 ` Kevin Chen
2025-03-04 10:44 ` [PATCH v2 3/3] soc: aspeed: lpc-pcc: Add PCC controller support Kevin Chen
2025-03-04 10:59 ` Krzysztof Kozlowski
2025-03-10 10:05 ` Kevin Chen
2025-03-10 11:43 ` Krzysztof Kozlowski
2025-03-11 0:17 ` Kevin Chen
2025-03-04 21:20 ` Christophe JAILLET
2025-03-10 2:15 ` Kevin Chen
2025-03-05 23:19 ` kernel test robot
2025-03-10 7:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=142a2edc-a668-4a6a-a4e8-eff3e8bf9e91@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.