From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v5 04/24] Debian: refactor code to add preseed commands to the preseed file Date: Wed, 29 Apr 2015 03:32:03 +0100 Message-ID: <1430274723.12403.120.camel@citrix.com> References: <1429094135.15516.187.camel@citrix.com> <1429094149-6849-4-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429094149-6849-4-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com Cc: "Hu, Robert" , "Pang, LongtaoX" , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-04-15 at 11:35 +0100, Ian Campbell wrote: > diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install > index cfd5144..95fce9a 100755 > --- a/ts-debian-hvm-install > +++ b/ts-debian-hvm-install > @@ -77,6 +77,9 @@ d-i preseed/late_command string \\ > in-target mkdir -p /root/.ssh; \\ > in-target sh -c "echo -e '$authkeys'> /root/.ssh/authorized_keys"; > END > + > + $preseed_file .= preseed_hook_cmds(); Longtao reused this patch for his nestedhvm testing series and discovered a bug. The use of preseed_hook_cmds shadows the preseed/late_command which is just visible here in the patch context meaning that the authorized keys and update-rc.d are not actually run. The code snippet needs to use a "preseed_hook_command($ho, 'late_command', $sfx, <