From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: libxl, flexarray_append_pair usage
Date: Fri, 1 May 2015 14:33:20 +0100 [thread overview]
Message-ID: <1430487200.15640.30.camel@citrix.com> (raw)
In-Reply-To: <20150424091600.GA11059@aepfle.de>
On Fri, 2015-04-24 at 11:16 +0200, Olaf Hering wrote:
> On Fri, Apr 24, Olaf Hering wrote:
>
> > flexarray_append(back, "state");
> > - flexarray_append(back, GCSPRINTF("%d", 1));
> > + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
>
> Should all such code be converted to flexarray_append_pair?
If you are touching the line anyway then I suppose that would be a good
thing, although not mandatory.
I don't think it is worth going through and proactively changing things.
> To reduce line length a short macro should be added, like FLXAP or
> FLXPAIR or something else.
Not sure about this, the macro doesn't save very much and FLX is a bit
opaque, I'd be inclined to just do normal wrapping for now.
Ian.
prev parent reply other threads:[~2015-05-01 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 9:16 libxl, flexarray_append_pair usage Olaf Hering
2015-04-24 9:23 ` Wei Liu
2015-05-01 13:33 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430487200.15640.30.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.