From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST RFC] Osstest/Debian.pm: Use Fqdn
 hostprop when collecting host keys
Date: Fri, 1 May 2015 15:09:23 +0100
Message-ID: <1430489363.15640.46.camel@citrix.com>
References: <1430487758-21972-1-git-send-email-ian.campbell@citrix.com>
	<21827.34001.74893.628888@mariner.uk.xensource.com>
	<1430488789.15640.39.camel@citrix.com>
	<21827.34843.408428.309278@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21827.34843.408428.309278@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-01 at 15:05 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST RFC] Osstest/Debian.pm: Use Fqdn hostprop when collecting host keys"):
> > That code is:
> > 
> >     my $defaultfqdn = $name;
> >     $defaultfqdn .= ".$c{TestHostDomain}" unless $defaultfqdn =~ m/\./;
> >     $ho->{Fqdn} = get_host_property($ho,'fqdn',$defaultfqdn);
> > 
> > Perhaps for now I should write:
> > 
> >         my $defaultfqdn = $node;
> >         $defaultfqdn .= ".$c{TestHostDomain}" unless $defaultfqdn =~ m/\./;
> >         
> >         my %props;
> >         $mhostdb->get_properties($node, \%props);
> >         
> >         my $longname= $props{Fqdn} ? $props{Fqdn} : $defaultfqdn;
> > 
> > ?
> 
> Sure.  Except you probably mean
> 
>           my $longname= $props{Fqdn} // $defaultfqdn;

Indeed I do, thanks.

I'll push the resulting patch to the Cambridge instance production
branch.

> 
> > Mainly becuase here in preseed_create we lack a $ho object I think.
> 
> Indeed.
> 
> Ian.