From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 4/6] sg-report-flight: Better choice
 of column-head cell
Date: Fri, 1 May 2015 16:19:51 +0100
Message-ID: <1430493591.15640.66.camel@citrix.com>
References: <21827.30808.198577.574772@mariner.uk.xensource.com>
	<1430492568-1761-1-git-send-email-ian.jackson@eu.citrix.com>
	<1430492568-1761-5-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YoCjq-0008Ex-HL
	for xen-devel@lists.xenproject.org; Fri, 01 May 2015 15:20:26 +0000
In-Reply-To: <1430492568-1761-5-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-01 at 16:02 +0100, Ian Jackson wrote:
> We are more interested the first worst failure.  But if everything
                       ^in ?

> passed, then the last pass.

> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  sg-report-flight |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sg-report-flight b/sg-report-flight
> index 29b5ef6..7c9e52e 100755
> --- a/sg-report-flight
> +++ b/sg-report-flight
> @@ -949,7 +949,7 @@ END
>      }
>      print H "\n";
>      print H "<tr><th>";
> -    print H "Worst/last";
> +    print H "Last pass / First worst fail";
>      print H "</th>";
>  
>      my $cell_html = sub {
> @@ -990,6 +990,7 @@ END
>  	    next unless $ei;
>  	    my @this = $cell_html->($ei);
>  	    next if $this[1] < $worst[1];
> +	    next if $this[1] == $worst[1] && $ei->{Step}{status} ne 'pass';
>  	    @worst=@this;
>  	}
>  	print H "<td ",$worst[2],">",$worst[0],"</td>";