From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 6/6] sg-report-flight: Report stepno
 and testid of first worst fail
Date: Fri, 1 May 2015 16:27:24 +0100
Message-ID: <1430494044.15640.71.camel@citrix.com>
References: <21827.30808.198577.574772@mariner.uk.xensource.com>
	<1430492568-1761-1-git-send-email-ian.jackson@eu.citrix.com>
	<1430492568-1761-7-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YoCqe-0000PH-Uo
	for xen-devel@lists.xenproject.org; Fri, 01 May 2015 15:27:29 +0000
In-Reply-To: <1430492568-1761-7-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-01 at 16:02 +0100, Ian Jackson wrote:
> This makes reading the scoreboard considerably easier.
> 
> We abuse the local variable @worst slight, pushing the extra info we
                                          ^ly

> @@ -993,9 +995,13 @@ END
>  	    next if $this[1] < $worst[1];
>  	    next if $this[1] == $worst[1] && $ei->{Step}{status} ne 'pass';
>  	    @worst=@this;
> +	    push @worst,
> +	        encode_entities("$ei->{Step}{stepno}. $ei->{Step}{testid}");
>  	}
> -	print H "<td ",$worst[2],">",$worst[0],"</td>";
> +	push @worstrow1, "<td ",$worst[2],">",$worst[3],"</td>";
> +	push @worstrow2, "<td ",$worst[2],">",$worst[0],"</td>";
>      }
> +    print H "\n", @worstrow1, "\n<tr>\n", @worstrow2;

Does this need a </tr> in the middle?

I think there was likely no </tr> in the old code either, and I suppose
web standards being what they are <tr>...<tr>...<tr>... probably works.

That being the case you could reasonably defer shaving this yakk for
another time.

>      print H "\n";
>      # Create a gutter row after the headers.
>      print H "<tr><td>&nbsp;</td></tr>\n";