All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Reitmayr <treitmayr@devbase.at>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH] media: Fix regression in some more dib0700 based devices.
Date: Sat, 02 May 2015 09:19:11 +0200	[thread overview]
Message-ID: <1430551151.29019.6.camel@devbase.at> (raw)
In-Reply-To: <1430522284-9138-1-git-send-email-treitmayr@devbase.at>

Hi,
as indicated by the "Fixes:" commit, this problem exists from kernel
version 3.17 up until now. Please consider forwarding the fix to
linux-stable if it looks ok to you.
Best regards,
-Thomas


Am Samstag, den 02.05.2015, 01:18 +0200 schrieb Thomas Reitmayr:
> Fix an oops during device initialization by correctly setting size_of_priv
> instead of leaving it 0.
> The regression was introduced by 8abe4a0a3f6d4217b16a ("[media] dib7000:
> export just one symbol") and only fixed for one type of dib0700 based
> devices in 9e334c75642b6e5bfb95 ("[media] Fix regression in some dib0700
> based devices").
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=92301
> 
> Fixes: 8abe4a0a3f6d4217b16a ("[media] dib7000: export just one symbol")
> Signed-off-by: Thomas Reitmayr <treitmayr@devbase.at>
> ---
>  drivers/media/usb/dvb-usb/dib0700_devices.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
> index 90cee38..e87ce83 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
> @@ -3944,6 +3944,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
>  
>  				DIB0700_DEFAULT_STREAMING_CONFIG(0x02),
>  			}},
> +				.size_of_priv = sizeof(struct
> +						dib0700_adapter_state),
>  			}, {
>  			.num_frontends = 1,
>  			.fe = {{
> @@ -3956,6 +3958,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
>  
>  				DIB0700_DEFAULT_STREAMING_CONFIG(0x03),
>  			}},
> +				.size_of_priv = sizeof(struct
> +						dib0700_adapter_state),
>  			}
>  		},
>  
> @@ -4009,6 +4013,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
>  
>  				DIB0700_DEFAULT_STREAMING_CONFIG(0x02),
>  			}},
> +				.size_of_priv = sizeof(struct
> +						dib0700_adapter_state),
>  			},
>  		},
>  


      reply	other threads:[~2015-05-02  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 23:18 [PATCH] media: Fix regression in some more dib0700 based devices Thomas Reitmayr
2015-05-02  7:19 ` Thomas Reitmayr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430551151.29019.6.camel@devbase.at \
    --to=treitmayr@devbase.at \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.