From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40973 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbbEBM54 (ORCPT ); Sat, 2 May 2015 08:57:56 -0400 Subject: Patch "compal-laptop: Fix leaking hwmon device" has been added to the 3.19-stable tree To: k.kozlowski@samsung.com, dvhart@linux.intel.com, gregkh@linuxfoundation.org, linux@roeck-us.net, sre@kernel.org Cc: , From: Date: Sat, 02 May 2015 14:57:37 +0200 Message-ID: <143057145718450@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled compal-laptop: Fix leaking hwmon device to the 3.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: compal-laptop-fix-leaking-hwmon-device.patch and it can be found in the queue-3.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ad774702f1705c04e5fa492b793d8d477a504fa6 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Thu, 12 Mar 2015 08:43:59 +0100 Subject: compal-laptop: Fix leaking hwmon device From: Krzysztof Kozlowski commit ad774702f1705c04e5fa492b793d8d477a504fa6 upstream. The commit c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") wanted to change the registering of hwmon device to resource-managed version. It mostly did it except the main thing - it forgot to use devm-like function so the hwmon device leaked after device removal or probe failure. Signed-off-by: Krzysztof Kozlowski Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") Acked-by: Guenter Roeck Acked-by: Darren Hart Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/compal-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c @@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_ if (err) return err; - hwmon_dev = hwmon_device_register_with_groups(&pdev->dev, - "compal", data, - compal_hwmon_groups); + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, + "compal", data, + compal_hwmon_groups); if (IS_ERR(hwmon_dev)) { err = PTR_ERR(hwmon_dev); goto remove; Patches currently in stable-queue which might be from k.kozlowski@samsung.com are queue-3.19/compal-laptop-fix-leaking-hwmon-device.patch queue-3.19/compal-laptop-check-return-value-of-power_supply_register.patch queue-3.19/power_supply-twl4030_madc-check-return-value-of-power_supply_register.patch queue-3.19/power_supply-ipaq_micro_battery-fix-leaking-workqueue.patch queue-3.19/power_supply-lp8788-charger-fix-leaked-power-supply-on-probe-fail.patch queue-3.19/power_supply-ipaq_micro_battery-check-return-values-in-probe.patch