From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41023 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbbEBM6z (ORCPT ); Sat, 2 May 2015 08:58:55 -0400 Subject: Patch "staging: android: sync: Fix memory corruption in sync_timeline_signal()." has been added to the 3.19-stable tree To: alistair.strachan@imgtec.com, ccross@google.com, gregkh@linuxfoundation.org, maarten.lankhorst@canonical.com Cc: , From: Date: Sat, 02 May 2015 14:58:04 +0200 Message-ID: <1430571484135194@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled staging: android: sync: Fix memory corruption in sync_timeline_signal(). to the 3.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: staging-android-sync-fix-memory-corruption-in-sync_timeline_signal.patch and it can be found in the queue-3.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 8e43c9c75faf2902955bd2ecd7a50a8cc41cb00a Mon Sep 17 00:00:00 2001 From: Alistair Strachan Date: Tue, 24 Mar 2015 14:51:31 -0700 Subject: staging: android: sync: Fix memory corruption in sync_timeline_signal(). From: Alistair Strachan commit 8e43c9c75faf2902955bd2ecd7a50a8cc41cb00a upstream. The android_fence_release() function checks for active sync points by calling list_empty() on the list head embedded on the sync point. However, it is only valid to use list_empty() on nodes that have been initialized with INIT_LIST_HEAD() or list_del_init(). Because the list entry has likely been removed from the active list by sync_timeline_signal(), there is a good chance that this WARN_ON_ONCE() will be hit due to dangling pointers pointing at freed memory (even though the sync drivers did nothing wrong) and memory corruption will ensue as the list entry is removed for a second time, corrupting the active list. This problem can be reproduced quite easily with CONFIG_DEBUG_LIST=y and fences with more than one sync point. Signed-off-by: Alistair Strachan Cc: Maarten Lankhorst Cc: Greg Kroah-Hartman Cc: Colin Cross Signed-off-by: Greg Kroah-Hartman --- drivers/staging/android/sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -114,7 +114,7 @@ void sync_timeline_signal(struct sync_ti list_for_each_entry_safe(pt, next, &obj->active_list_head, active_list) { if (fence_is_signaled_locked(&pt->base)) - list_del(&pt->active_list); + list_del_init(&pt->active_list); } spin_unlock_irqrestore(&obj->child_list_lock, flags); Patches currently in stable-queue which might be from alistair.strachan@imgtec.com are queue-3.19/staging-android-sync-fix-memory-corruption-in-sync_timeline_signal.patch