From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:41371 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbbECTHv (ORCPT ); Sun, 3 May 2015 15:07:51 -0400 Message-ID: <1430680059.3276.1.camel@sipsolutions.net> (sfid-20150503_210759_963997_6DE07ED7) Subject: Re: [PATCH] backports: mac80211: revert to old stats behaviour for older kernels From: Johannes Berg To: Arend van Spriel Cc: "Luis R. Rodriguez" , backports@vger.kernel.org Date: Sun, 03 May 2015 21:07:39 +0200 In-Reply-To: <1430487994-20598-1-git-send-email-arend@broadcom.com> (sfid-20150501_154642_126166_7597CA83) References: <1430487994-20598-1-git-send-email-arend@broadcom.com> (sfid-20150501_154642_126166_7597CA83) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: backports-owner@vger.kernel.org List-ID: On Fri, 2015-05-01 at 15:46 +0200, Arend van Spriel wrote: > Commit 5a490510ba5f ("mac80211: use per-CPU TX/RX statistics") introduced > the use of per-cpu statistics, ie. struct netdevice::tstats. This is not > supported in kernel 3.14 and older. > > Signed-off-by: Arend van Spriel > --- > I am not entirely sure whether 3.14 is the correct version to check for. The > functionality seems introduced there but there were some subsequent patches > on the per-cpu netdev stats functionality. I don't really like just reverting to the old behaviour - that'll make this very hard to port. What part of this isn't supported? Is there no pointer whatsoever that we can use? We still implement the ndo_getstats64 [or whatever it's called] ourselves anyway, so we don't really use any API here apart from * netdev_alloc_pcpu_stats, which is trivially backported * dev->tstats, which is just a single pointer and we could use anything else, even perhaps in sdata johannes