From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: [OSSTEST] (Probably benign) bug in create_webfile
Date: Tue, 5 May 2015 10:24:33 +0100 [thread overview]
Message-ID: <1430817873.2660.8.camel@citrix.com> (raw)
In
http://www.chiark.greenend.org.uk/~xensrcts/logs/37298/test-amd64-amd64-xl-qemut-debianhvm-amd64/info.html
I was incorrectly passing a $ho to preseed_hook_script when I meant
$gho, this meant that instead of
webspace-lake-frog_debianhvm.guest.osstest_late_command-2 it ended up
trying to create webspace-lake-frog_late_command-2 which clashed with a
file left over from the host install and ended up automatically renamed
as webspace-lake-frog_late_command-2+1, however the guest preseed file
ended up referencing the original/indented name and not the actual one.
preseed_hook_script pays attention to the url returned by create_webfile
so I think the issue is further down. I suspect that create_webfile
needs to pay attention to something which should be returned by
file_link_contents.
I was passing the wrong thing, so I've just fixed that but this bug
might bite someone in the future, especially if rerunning test steps in
standalone mode.
Something to watch out for.
Ian.
reply other threads:[~2015-05-05 9:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430817873.2660.8.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.