From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST] (Probably benign) bug in create_webfile
Date: Tue, 5 May 2015 10:24:33 +0100
Message-ID: <1430817873.2660.8.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

In
http://www.chiark.greenend.org.uk/~xensrcts/logs/37298/test-amd64-amd64-xl-qemut-debianhvm-amd64/info.html

I was incorrectly passing a $ho to preseed_hook_script when I meant
$gho, this meant that instead of
webspace-lake-frog_debianhvm.guest.osstest_late_command-2 it ended up
trying to create webspace-lake-frog_late_command-2 which clashed with a
file left over from the host install and ended up automatically renamed
as webspace-lake-frog_late_command-2+1, however the guest preseed file
ended up referencing the original/indented name and not the actual one.

preseed_hook_script pays attention to the url returned by create_webfile
so I think the issue is further down. I suspect that create_webfile
needs to pay attention to something which should be returned by
file_link_contents.

I was passing the wrong thing, so I've just fixed that but this bug
might bite someone in the future, especially if rerunning test steps in
standalone mode.

Something to watch out for.

Ian.