From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 13/14] tools: add tools support for Intel CAT Date: Tue, 5 May 2015 23:33:42 +0200 Message-ID: <1430861622.5415.60.camel@citrix.com> References: <1429782951-18813-1-git-send-email-chao.p.peng@linux.intel.com> <1429782951-18813-14-git-send-email-chao.p.peng@linux.intel.com> <1430830376.2660.79.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7121796258193049285==" Return-path: In-Reply-To: <1430830376.2660.79.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, Chao Peng , dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org --===============7121796258193049285== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VW0eAhr22D9IawD61GiR" --=-VW0eAhr22D9IawD61GiR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-05-05 at 13:52 +0100, Ian Campbell wrote: > On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote: > > @@ -1495,10 +1495,20 @@ for any of these monitoring types. > > =20 > > =3Dover 4 > > =20 > > -=3Ditem B > > +=3Ditem B [I] > > =20 > > Show CMT hardware information. > > =20 > > +B > > + > > +=3Dover 4 > > + > > +=3Ditem B<-m>, B<--cmt> > > + > > +Show Cache Monitoring Technology (CMT) hardware information. >=20 > Duplicating the psr-hwinfo case for CMT and CAT is confusing. >=20 > I suggest to add =3Dhead1 and to push the > existing "=3Dhead1 CACHE MONITORING TECHNOLOGY" to a =3Dhead2, and the sa= me > for the new CACHE ALLOCATION TECHNOLOGY section. >=20 > i.e. have an overall PSR section and then subsections for CMT and CAT. >=20 > psr-hwinfo would then be described at the top level and the CMD/CAT > specifics in the relevant section. >=20 > Does that sound ok? >=20 +1 > > +=3Dhead1 CACHE ALLOCATION TECHNOLOGY > > + > > +Intel Broadwell and later server platforms offer capabilities to confi= gure and > > +make use of the Cache Allocation Technology (CAT) mechanisms, which en= able more > > +cache resources (i.e. L3 cache) to be made available for high priority > > +applications. In Xen implementation, CAT is used to control cache allo= cation > ^the >=20 > > diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c > > index b81b3ff..eede5f1 100644 > > --- a/tools/libxl/xl_cmdtable.c > > +++ b/tools/libxl/xl_cmdtable.c > > @@ -527,7 +527,9 @@ struct cmd_spec cmd_table[] =3D { > > { "psr-hwinfo", > > &main_psr_hwinfo, 0, 1, > > "Show hardware information for Platform Shared Resource", > > - "", > > + "[options]", > > + "-m Show Cache Monitoring Technology (CMT) hardware = info\n" > > + "-a Show Cache Allocation Technology (CAT) hardware = info\n" >=20 > and seem out of place here, since -m and -a do not take > options AFAICT. >=20 Chao, maybe you meant something like this? "-m, --cmt Show Cache Monitoring Technology (CMT) hardware info\n" "-a, --cat Show Cache Allocation Technology (CAT) hardware info\n" Dario --=-VW0eAhr22D9IawD61GiR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlVJNzcACgkQk4XaBE3IOsSsaACfeNmgwjjeOm5CflDZcMW3KA96 y/kAnRrS5Ra8FMgICY4r7Hy8LFJAXpMQ =LbBB -----END PGP SIGNATURE----- --=-VW0eAhr22D9IawD61GiR-- --===============7121796258193049285== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7121796258193049285==--