From: Joe Perches <joe@perches.com>
To: Eddie Huang <eddie.huang@mediatek.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
srv_heupstream@mediatek.com, Samuel Ortiz <sameo@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Tomasz Figa <tfiga@google.com>,
Tianping Fang <tianping.fang@mediatek.com>
Subject: Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver
Date: Wed, 06 May 2015 00:44:59 -0700 [thread overview]
Message-ID: <1430898299.9365.74.camel@perches.com> (raw)
In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com>
On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> From: Tianping Fang <tianping.fang@mediatek.com>
trivia: no need to resend now, maybe in a future patch.
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
[]
> +static int mtk_rtc_probe(struct platform_device *pdev)
> +{
[]
> + ret = request_threaded_irq(rtc->irq, NULL,
> + mtk_rtc_irq_handler_thread,
> + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> + "mt6397-rtc", rtc);
It'd be nicer to align all the statement lines
to that open parenthesis
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Eddie Huang <eddie.huang@mediatek.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
srv_heupstream@mediatek.com, Samuel Ortiz <sameo@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Tomasz Figa <tfiga@google.com>,
Tianping Fang <tianping.fang@mediatek.com>
Subject: [rtc-linux] Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver
Date: Wed, 06 May 2015 00:44:59 -0700 [thread overview]
Message-ID: <1430898299.9365.74.camel@perches.com> (raw)
In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com>
On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> From: Tianping Fang <tianping.fang@mediatek.com>
trivia: no need to resend now, maybe in a future patch.
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
[]
> +static int mtk_rtc_probe(struct platform_device *pdev)
> +{
[]
> + ret = request_threaded_irq(rtc->irq, NULL,
> + mtk_rtc_irq_handler_thread,
> + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> + "mt6397-rtc", rtc);
It'd be nicer to align all the statement lines
to that open parenthesis
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver
Date: Wed, 06 May 2015 00:44:59 -0700 [thread overview]
Message-ID: <1430898299.9365.74.camel@perches.com> (raw)
In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com>
On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> From: Tianping Fang <tianping.fang@mediatek.com>
trivia: no need to resend now, maybe in a future patch.
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
[]
> +static int mtk_rtc_probe(struct platform_device *pdev)
> +{
[]
> + ret = request_threaded_irq(rtc->irq, NULL,
> + mtk_rtc_irq_handler_thread,
> + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> + "mt6397-rtc", rtc);
It'd be nicer to align all the statement lines
to that open parenthesis
next prev parent reply other threads:[~2015-05-06 7:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 7:23 [PATCH v4 0/3] Add Mediatek SoC RTC driver Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` [rtc-linux] " Eddie Huang
2015-05-06 7:23 ` [PATCH v4 1/3] mfd: provide RTC resource in MT6397 MFD Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` [rtc-linux] " Eddie Huang
2015-05-06 7:23 ` [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` [rtc-linux] " Eddie Huang
2015-05-06 7:44 ` Joe Perches [this message]
2015-05-06 7:44 ` Joe Perches
2015-05-06 7:44 ` [rtc-linux] " Joe Perches
2015-05-07 12:06 ` Alexandre Belloni
2015-05-07 12:06 ` Alexandre Belloni
2015-05-07 12:06 ` [rtc-linux] " Alexandre Belloni
2015-05-07 15:06 ` Eddie Huang
2015-05-07 15:06 ` Eddie Huang
2015-05-07 15:06 ` Eddie Huang
2015-05-07 15:06 ` [rtc-linux] " Eddie Huang
2015-05-06 7:23 ` [PATCH v4 3/3] MAINTAINERS: add Mediatek " Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` Eddie Huang
2015-05-06 7:23 ` [rtc-linux] " Eddie Huang
2015-05-09 13:08 ` [PATCH v4 0/3] Add Mediatek SoC " Alexandre Belloni
2015-05-09 13:08 ` Alexandre Belloni
2015-05-09 13:08 ` [rtc-linux] " Alexandre Belloni
2015-05-12 8:15 ` Daniel Kurtz
2015-05-12 8:15 ` Daniel Kurtz
2015-05-12 8:15 ` [rtc-linux] " Daniel Kurtz
[not found] ` <CAGS+omArcu3caKZo56Db2u+84WAVJiMzkr+1uS6tr_zfwARQ7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-12 8:41 ` Alexandre Belloni
2015-05-12 8:41 ` Alexandre Belloni
2015-05-12 8:41 ` Alexandre Belloni
2015-05-12 8:41 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430898299.9365.74.camel@perches.com \
--to=joe@perches.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=davem@davemloft.net \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tianping.fang@mediatek.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.