From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver Date: Wed, 06 May 2015 00:44:59 -0700 Message-ID: <1430898299.9365.74.camel@perches.com> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Eddie Huang Cc: Lee Jones , Alessandro Zummo , Alexandre Belloni , srv_heupstream@mediatek.com, Samuel Ortiz , Matthias Brugger , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Tejun Heo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sascha Hauer , Tomasz Figa , Tianping Fang List-Id: linux-mediatek@lists.infradead.org On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > From: Tianping Fang trivia: no need to resend now, maybe in a future patch. > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c [] > +static int mtk_rtc_probe(struct platform_device *pdev) > +{ [] > + ret = request_threaded_irq(rtc->irq, NULL, > + mtk_rtc_irq_handler_thread, > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > + "mt6397-rtc", rtc); It'd be nicer to align all the statement lines to that open parenthesis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0221.hostedemail.com. [216.40.44.221]) by gmr-mx.google.com with ESMTP id 48si959917yhx.3.2015.05.06.00.45.03 for ; Wed, 06 May 2015 00:45:03 -0700 (PDT) Message-ID: <1430898299.9365.74.camel@perches.com> Subject: [rtc-linux] Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver From: Joe Perches To: Eddie Huang Cc: Lee Jones , Alessandro Zummo , Alexandre Belloni , srv_heupstream@mediatek.com, Samuel Ortiz , Matthias Brugger , Andrew Morton , Greg KH , "David S. Miller" , Mauro Carvalho Chehab , Tejun Heo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sascha Hauer , Tomasz Figa , Tianping Fang Date: Wed, 06 May 2015 00:44:59 -0700 In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Mime-Version: 1.0 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > From: Tianping Fang trivia: no need to resend now, maybe in a future patch. > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c [] > +static int mtk_rtc_probe(struct platform_device *pdev) > +{ [] > + ret = request_threaded_irq(rtc->irq, NULL, > + mtk_rtc_irq_handler_thread, > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > + "mt6397-rtc", rtc); It'd be nicer to align all the statement lines to that open parenthesis -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Wed, 06 May 2015 00:44:59 -0700 Subject: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver In-Reply-To: <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> References: <1430897022-63357-1-git-send-email-eddie.huang@mediatek.com> <1430897022-63357-3-git-send-email-eddie.huang@mediatek.com> Message-ID: <1430898299.9365.74.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote: > From: Tianping Fang trivia: no need to resend now, maybe in a future patch. > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c [] > +static int mtk_rtc_probe(struct platform_device *pdev) > +{ [] > + ret = request_threaded_irq(rtc->irq, NULL, > + mtk_rtc_irq_handler_thread, > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, > + "mt6397-rtc", rtc); It'd be nicer to align all the statement lines to that open parenthesis