From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] tools: add configure --with-dumpdir=DIR
	option
Date: Fri, 8 May 2015 10:37:42 +0100
Message-ID: <1431077862.2660.416.camel@citrix.com>
References: <1430896124-604-1-git-send-email-olaf@aepfle.de>
	<20150507080144.GA28443@zion.uk.xensource.com>
	<20150507081051.GA18798@aepfle.de>
	<1430990570.2660.337.camel@citrix.com>
	<20150508065412.GC4342@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150508065412.GC4342@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-08 at 08:54 +0200, Olaf Hering wrote:
> On Thu, May 07, Ian Campbell wrote:
> 
> > On Thu, 2015-05-07 at 10:10 +0200, Olaf Hering wrote:
> > > On Thu, May 07, Wei Liu wrote:
> > > 
> > > > On Wed, May 06, 2015 at 07:08:44AM +0000, Olaf Hering wrote:
> > > > > The current base directory /var/xen for domU dumps will be patched to
> > > > > /var/lib/xen by most distros. Provide a configure option to avoid
> > > > > patching the source.
> > > 
> > > 
> > > > > If the option is not specified the default remains /var/xen/dump.
> > > > You have not patched docs. I think it still references /var/xen/dump.
> > > > I discovered this when I read the manpage of xl.cfg.
> > > 
> > > The default does not change. Last time I looked the docs refer to both
> > > /var/xen/dump and /var/lib/xen/dump. Do you want me to update the
> > > example in xl.cfg?
> > 
> > Does anyone actually use the non-FHS compliant current default
> > of /var/xen/dump? Should we consider switching it to something more
> > standard? Perhaps having done so making it configurable wouldn't be
> > useful any more (although I'd be happy with it being so if desired).
> 
> Changing the default would work as well I think. Right now the path is
> hardcoded. Should I adjust the patch to honour --localstatedir= or leave
> the hardcoded path in the source?

I don't mind really, but since you've already got the code for the
former we may as well keep it but just change the default.

Ian.