From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 12/19] xen: arm: Annotate the handlers for HSTR_EL2.T15 Date: Fri, 8 May 2015 11:17:20 +0100 Message-ID: <1431080240.2660.422.camel@citrix.com> References: <1429279300.25195.330.camel@citrix.com> <1429279315-32143-12-git-send-email-ian.campbell@citrix.com> <553BD359.3000104@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <553BD359.3000104@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sat, 2015-04-25 at 22:48 +0500, Julien Grall wrote: > Hi Ian, > > On 17/04/2015 19:01, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > --- > > v2: s/Tx/T15/ > > --- > > xen/arch/arm/traps.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > > index a2bae51..86b5655 100644 > > --- a/xen/arch/arm/traps.c > > +++ b/xen/arch/arm/traps.c > > @@ -1720,6 +1720,11 @@ static void do_cp15_32(struct cpu_user_regs *regs, > > * ARMv7 (DDI 0406C.b): B1.14.12 > > * ARMv8 (DDI 0487A.d): N/A > > * > > + * HSTR_EL2.T15 > > + * > > + * ARMv7 (DDI 0406C.b): B1.14.14 > > + * ARMv8 (DDI 0487A.d): D1-1507 Table D1-55 > > + * > > * And all other unknown registers. > > */ > > default: > > @@ -1758,6 +1763,11 @@ static void do_cp15_64(struct cpu_user_regs *regs, > > * ARMv7 (DDI 0406C.b): B1.14.12 > > * ARMv8 (DDI 0487A.d): N/A > > * > > + * HSTR_EL2.Tx > > Should not this Tx switch to T15 too? It should and apparently I've already changed it in my tree for v3, not sure when I did that!