From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 3/5] xen: arm: slightly refactor gic DT node creation for domain 0 Date: Fri, 8 May 2015 11:38:09 +0100 Message-ID: <1431081489.2660.426.camel@citrix.com> References: <1429532129.25195.422.camel@citrix.com> <1429532165-19069-3-git-send-email-ian.campbell@citrix.com> <5540FFFF.7070400@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5540FFFF.7070400@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, Chen Baozi , Suravee Suthikulanit List-Id: xen-devel@lists.xenproject.org On Wed, 2015-04-29 at 16:59 +0100, Julien Grall wrote: > Hi Ian, > > On 20/04/15 13:16, Ian Campbell wrote: > > all gics. > > Shouldn't it belong to the subject? It doesn't seem to fit their either. I'm not really sure what it was supposed to be, perhaps a remnant of a half finished thought I intended to delete. I've just dropped it. > > > Although in principal #interrupt-cells can vary it must always be 3 > > for a GIC (and we only support GIC as a guest interrupt controller), > > so putting it in common code is OK. > > > > Signed-off-by: Ian Campbell > > Other than the subject title: > > Reviewed-by: Julien Grall Thanks, I've kept this even though I dropped those words rather than moving them, let me know if this is a problem. Ian.