From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 3/3] libxc/migrationv2: Split {start,
 end}_of_stream() to make checkpoint variants
Date: Fri, 8 May 2015 15:12:53 +0100
Message-ID: <1431094373.2660.476.camel@citrix.com>
References: <1431089675-31163-1-git-send-email-andrew.cooper3@citrix.com>
	<1431089675-31163-4-git-send-email-andrew.cooper3@citrix.com>
	<1431091837.2660.449.camel@citrix.com> <554CBC13.1050906@citrix.com>
	<1431093006.2660.460.camel@citrix.com> <554CC03C.5050708@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <554CC03C.5050708@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-08 at 14:55 +0100, Andrew Cooper wrote:
> On 08/05/15 14:50, Ian Campbell wrote:
> > On Fri, 2015-05-08 at 14:37 +0100, Andrew Cooper wrote:
> >> Does Remus currently function if the sending toolstack suddenly
> >> disappears out of the mix?
> > I would assume so, that's its entire purpose...
> 
> But the signal to resume the domain properly involves setting
> last_checkpoint and wandering the recieve loop once more?
> 
> /me goes and checks the code more carefully.

I think there's supposed to be a read timeout in there somewhere, at
which point the last checkpoint you did manage to get is the one which
is used.

(The heartbeating and detection of this stuff bit of remus was always a
bit underwhelming)

Ian.