From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] config: generate Paths-$SUBSYSTEM.mk
Date: Fri, 8 May 2015 15:43:14 +0100
Message-ID: <1431096194.2660.484.camel@citrix.com>
References: <1430888562-3745-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1430888562-3745-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-05-06 at 06:02 +0100, Wei Liu wrote:
> ... so that we can run ./configure in each subsystem.
> 
> Make inclusion of Paths-*.mk mandatory. Skip generating a global
> Paths.mk since it's of no use anymore.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> v2: update .gitignore, delete Paths-*.mk in distclean
> 
> Please rerun autogen.sh when applying this patch.

With this applied the list of installed files changes in a way which is
clearly not desirable ;-).

Looks like the stubdom case is not correctly handled?

--- ../FILE_LIST.BASE.staging.x86_64    2015-04-15 16:03:29.000000000 +0100
+++ ../FILE_LIST.staging.x86_64 2015-05-08 15:41:21.000000000 +0100
@@ -56,6 +56,9 @@
 dist/install/etc/xen/xl.conf
 dist/install/etc/xen/xlexample.hvm
 dist/install/etc/xen/xlexample.pvlinux
+dist/install@LIBEXEC_BIN@
+dist/install@LIBEXEC_BIN@/stubdom-dm
+dist/install@LIBEXEC_BIN@/stubdompath.sh
 dist/install.sh
 dist/install/usr
 dist/install/usr/local
@@ -337,8 +340,6 @@
 dist/install/usr/local/lib/xen/bin/qemu-nbd
 dist/install/usr/local/lib/xen/bin/qemu-system-i386
 dist/install/usr/local/lib/xen/bin/readnotes
-dist/install/usr/local/lib/xen/bin/stubdom-dm
-dist/install/usr/local/lib/xen/bin/stubdompath.sh
 dist/install/usr/local/lib/xen/bin/xenconsole
 dist/install/usr/local/lib/xen/bin/xenctx
 dist/install/usr/local/lib/xen/bin/xendomains
@@ -347,12 +348,6 @@
 dist/install/usr/local/lib/xen/bin/xenpvnetboot
 dist/install/usr/local/lib/xen/boot
 dist/install/usr/local/lib/xen/boot/hvmloader
-dist/install/usr/local/lib/xen/boot/ioemu-stubdom.gz
-dist/install/usr/local/lib/xen/boot/pv-grub-x86_32.gz
-dist/install/usr/local/lib/xen/boot/pv-grub-x86_64.gz
-dist/install/usr/local/lib/xen/boot/vtpmmgr-stubdom.gz
-dist/install/usr/local/lib/xen/boot/vtpm-stubdom.gz
-dist/install/usr/local/lib/xen/boot/xenstore-stubdom.gz
 dist/install/usr/local/lib/xen/etc
 dist/install/usr/local/lib/xen/etc/qemu
 dist/install/usr/local/lib/xen/etc/qemu/target-x86_64.conf
@@ -785,4 +780,11 @@
 dist/install/var/log/xen
 dist/install/var/xen
 dist/install/var/xen/dump
+dist/install@XENFIRMWAREDIR@
+dist/install@XENFIRMWAREDIR@/ioemu-stubdom.gz
+dist/install@XENFIRMWAREDIR@/pv-grub-x86_32.gz
+dist/install@XENFIRMWAREDIR@/pv-grub-x86_64.gz
+dist/install@XENFIRMWAREDIR@/vtpmmgr-stubdom.gz
+dist/install@XENFIRMWAREDIR@/vtpm-stubdom.gz
+dist/install@XENFIRMWAREDIR@/xenstore-stubdom.gz
 dist/README
*** FILES DIFFER ***