From: festevam@gmail.com (Fabio Estevam)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2 4/4] coccinelle: simple_open: Use imperative mood
Date: Sat, 9 May 2015 17:09:30 -0300 [thread overview]
Message-ID: <1431202170-18055-4-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1431202170-18055-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
According to Documentation/SubmittingPatches:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."
So do as recommended.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
Changes since v1:
- None
scripts/coccinelle/api/simple_open.cocci | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/api/simple_open.cocci b/scripts/coccinelle/api/simple_open.cocci
index b67e174..bd1a2a4 100644
--- a/scripts/coccinelle/api/simple_open.cocci
+++ b/scripts/coccinelle/api/simple_open.cocci
@@ -1,5 +1,5 @@
-/// This removes an open coded simple_open() function
-/// and replaces file operations references to the function
+/// Remove an open coded simple_open() function
+/// and replace file operations references to the function
/// with simple_open() instead.
///
// Confidence: High
--
1.9.1
next prev parent reply other threads:[~2015-05-09 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:09 [Cocci] [PATCH v2 1/4] coccinelle: pm_runtime: Insert blank line Fabio Estevam
2015-05-09 20:09 ` [Cocci] [PATCH v2 2/4] coccinelle: returnvar: Use imperative mood Fabio Estevam
2015-05-09 20:09 ` [Cocci] [PATCH v2 3/4] coccinelle: ifaddr: Fix the sentence Fabio Estevam
2015-05-09 20:09 ` Fabio Estevam [this message]
2015-05-09 20:15 ` [Cocci] [PATCH v2 1/4] coccinelle: pm_runtime: Insert blank line Julia Lawall
2015-05-20 6:02 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431202170-18055-4-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.