Re: pvgrub regression in xen.git 123c77937975

[Ian Campbell <ian.campbell@citrix.com>]

On Sun, 2015-05-10 at 13:20 +0100, Wei Liu wrote:
> On Sun, May 10, 2015 at 07:19:09AM +0100, Ian Campbell wrote:
> > On Fri, 2015-05-08 at 17:16 +0100, Ian Campbell wrote:
> > > There seems to be a pvgrub regression somewhere in the range
> > > 3a28f760508f..123c77937975
> > 
> > The bisector has fingered:
> > 
> >         commit 840837907c6186307c19abbec926852ba448facd
> >           Author: Wei Liu <wei.liu2@citrix.com>
> >           Date:   Mon Mar 16 09:52:22 2015 +0000
> >           
> >               libxc: add p2m_size to xc_dom_image
> >         
> > Full report below. I've put a copy of the graph at:
> > http://xenbits.xen.org/people/ianc/tmp/201505/bisect.pvgrub.html
> > 
> > Wei, you can see an instance of the failure at
> > http://osstest.xs.citrite.net/~osstest/testlogs/logs/37344/
> 
> Unfortunately Citrix access gateway doesn't work for me at the moment so
> I couldn't see the log.

FWIW http://xenbits.xen.org/people/ianc/tmp/201505/37344/ (no build-*
logs, just test-*), but it looks like you don't actually need them.

> But I've looked at the code. PV grub's kexec function doesn't update the
> newly added field. I will try to reproduce on my local test box.

I've seen your patch, will take a proper look tomorrow.

Thanks for the quick turnaround!

Ian.