From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] tools/libxc: Fix missing break from c/s
 b49a7517
Date: Mon, 11 May 2015 11:48:14 +0100
Message-ID: <1431341294.8263.14.camel@citrix.com>
References: <1431118767-23667-1-git-send-email-andrew.cooper3@citrix.com>
	<554E4FBB.7050500@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <554E4FBB.7050500@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-05-09 at 19:19 +0100, Julien Grall wrote:
> Hi Andrew,
> 
> On 08/05/2015 21:59, Andrew Cooper wrote:
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Ian Campbell <Ian.Campbell@citrix.com>
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Julien Grall <julien.grall@citrix.com>
> > ---
> >   tools/libxc/xc_domain.c |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> > index 273e1fd..a7079a1 100644
> > --- a/tools/libxc/xc_domain.c
> > +++ b/tools/libxc/xc_domain.c
> > @@ -1978,6 +1978,7 @@ static int xc_domain_unbind_pt_irq_int(
> >           break;
> >       case PT_IRQ_TYPE_SPI:
> >           bind->u.spi.spi = spi;
> > +        break;
> 
> Sorry, I haven't spot this one because I didn't exercise this code path.
> 
> I did the same mistake in xc_domain_bint_pt_irq_int which I fixed during 
> testing.
> 
> Reviewed-by: Julien Grall <julien.grall@citrix.com>

Acked + applied, thanks.

Ian.